Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude subsections from SideNav, a11y audit #41

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Exclude subsections from SideNav, a11y audit #41

merged 1 commit into from
Dec 11, 2024
+35,287 −14,083

Conversation

nahbee10
Copy link

@nahbee10 nahbee10 commented Dec 11, 2024 •
edited
Loading

Description

  • excluded subsections from Side Nav items as per the client's request
  • changed link for the FAQ block in colored card section on homepage
  • a11y audit
    • updated text color
    • hid focusable elements when they are inside aria-hidden=true parent element
    • 100 for lighthouse a11y score

Type(s) of changes

  • Bug fix
  • New feature
  • Update to an existing feature

Motivation for PR

How Has This Been Tested?

Tested on preview

Applicable screenshots

  • side nav items before:
Screenshot 2024-12-11 at 9 41 58 PM
  • after:
Screenshot 2024-12-11 at 9 42 11 PM

Follow-up PR

@nahbee10 nahbee10 requested a review from mokaymokay December 11, 2024 12:45
@nahbee10 nahbee10 merged commit a9ce5da into master Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokaymokay mokaymokay mokaymokay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahbee10 @mokaymokay